[aspect-devel] Invalid parameters

[Eric Heien]

I added this, confirmed it works in optimized mode, and checked it in.

Thanks,

-Eric

On Mar 6, 2013, at 1:42 PM, Timo Heister wrote:

> Dear Eric,
> 
> yes, I guess it makes sense to check parameters coming from a file
> also in optimized mode. I think the easiest way would be to add
> AssertThrow(...) after reading in the values in Aspect.
> 
> On Wed, Mar 6, 2013 at 3:31 PM, Eric Heien <emheien at ucdavis.edu> wrote:
>> We recently ran into an issue with Aspect where it will accept parameter files with (Refinement fraction)+(Coarsening fraction) > 1.  There is an Assert() to catch this inside deal.II, but this gets removed in optimized mode.  Putting a similar Assert() in parameters.cc doesn't work for the same reason, and I believe the Assert() calls currently used for parameter checking won't catch parameter file problems in optimized mode.
>> 
>> Should these Assert() functions be changed to something that always get called in order to avoid running simulations with incorrect parameters?  Since parameters are only read once, there's no speed benefit from optimizing these out as occurs with Assert().
>> 
>> Thanks,
>> 
>> -Eric
>> 
>> _______________________________________________
>> Aspect-devel mailing list
>> Aspect-devel at geodynamics.org
>> http://geodynamics.org/cgi-bin/mailman/listinfo/aspect-devel
> 
> 
> 
> -- 
> Timo Heister
> http://www.math.tamu.edu/~heister/
> _______________________________________________
> Aspect-devel mailing list
> Aspect-devel at geodynamics.org
> http://geodynamics.org/cgi-bin/mailman/listinfo/aspect-devel