[cig-commits] r3995 - in long/3D/Gale/trunk/src/StgFEM: . Discretisation/src

[walter at geodynamics.org]

Author: walter
Date: 2006-07-09 14:36:37 -0700 (Sun, 09 Jul 2006)
New Revision: 3995

Modified:
   long/3D/Gale/trunk/src/StgFEM/
   long/3D/Gale/trunk/src/StgFEM/Discretisation/src/BilinearElementType.c
   long/3D/Gale/trunk/src/StgFEM/Discretisation/src/TrilinearElementType.c
Log:
 r683 at earth:  boo | 2006-07-09 14:30:59 -0700
  r680 at earth (orig r605):  PatrickSunter | 2006-07-06 23:49:34 -0700
  BilinearElementType and TrilinearElementType's functions to map
  a global coord to a local coord weren't zeroing the input xi
  coord, so for 2D probs this meant xi[2] was uninitialised,
  causing valgrind to complain. Fixed.
  
 



Property changes on: long/3D/Gale/trunk/src/StgFEM
___________________________________________________________________
Name: svk:merge
   - 38867592-cf10-0410-9e16-a142ea72ac34:/cig:670
db209038-57f2-0310-97fa-b160e0ae9d04:/trunk:604
   + 38867592-cf10-0410-9e16-a142ea72ac34:/cig:683
db209038-57f2-0310-97fa-b160e0ae9d04:/trunk:605

Modified: long/3D/Gale/trunk/src/StgFEM/Discretisation/src/BilinearElementType.c
===================================================================
--- long/3D/Gale/trunk/src/StgFEM/Discretisation/src/BilinearElementType.c	2006-07-09 21:36:31 UTC (rev 3994)
+++ long/3D/Gale/trunk/src/StgFEM/Discretisation/src/BilinearElementType.c	2006-07-09 21:36:37 UTC (rev 3995)
@@ -334,6 +334,9 @@
 		elLen[0] = (*(globalNodeCoordPtrsInElement[1]))[0] - (*(globalNodeCoordPtrsInElement[0]))[0];
 		elLen[1] = (*(globalNodeCoordPtrsInElement[3]))[1] - (*(globalNodeCoordPtrsInElement[0]))[1];
 		
+		/* Initially set elLocalCoord to (0,0,0) */
+		memset( elLocalCoord, 0, sizeof( Coord ) );
+	
 		for( dim_I=0; dim_I < 2; dim_I++ ) {
 			globalToElLocalScaling[dim_I] = self->elLocalLength[dim_I] / elLen[dim_I];
 

Modified: long/3D/Gale/trunk/src/StgFEM/Discretisation/src/TrilinearElementType.c
===================================================================
--- long/3D/Gale/trunk/src/StgFEM/Discretisation/src/TrilinearElementType.c	2006-07-09 21:36:31 UTC (rev 3994)
+++ long/3D/Gale/trunk/src/StgFEM/Discretisation/src/TrilinearElementType.c	2006-07-09 21:36:37 UTC (rev 3995)
@@ -304,6 +304,9 @@
 		** have to figure out a compromise for MG.  Luke - 03/08/2005
 		*/
 
+		/* Initially set elLocalCoord to (0,0,0) */
+		memset( elLocalCoord, 0, sizeof( Coord ) );
+	
 		for( dim_I=0; dim_I < 3; dim_I++ ) {
 			globalToElLocalScaling[dim_I] = self->elLocalLength[dim_I] / elLen[dim_I];
 			/* The bottom left node is always at index zero */