[cig-commits] r6859 - in short/3D/PyLith/trunk: . unittests/libtests/feassemble unittests/libtests/materials

brad at geodynamics.org brad at geodynamics.org
Fri May 11 16:18:12 PDT 2007


Author: brad
Date: 2007-05-11 16:18:12 -0700 (Fri, 11 May 2007)
New Revision: 6859

Modified:
   short/3D/PyLith/trunk/TODO
   short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegrator.cc
   short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegratorInertia.cc
   short/3D/PyLith/trunk/unittests/libtests/materials/TestElasticMaterial.cc
   short/3D/PyLith/trunk/unittests/libtests/materials/TestMaterial.cc
Log:
Updated TODO. Removed obsolete, superfluous typedefs.

Modified: short/3D/PyLith/trunk/TODO
===================================================================
--- short/3D/PyLith/trunk/TODO	2007-05-11 23:08:21 UTC (rev 6858)
+++ short/3D/PyLith/trunk/TODO	2007-05-11 23:18:12 UTC (rev 6859)
@@ -13,24 +13,17 @@
   dimensions, we probably want to allow it in MeshIO, just not in the
   simulation where we don't support it.
 
-  Use pylith/utils/sievefwd.hh and pylith/utils/sievetypes.hh in unit
-  tests. Remove typedefs when possible (take advantage of typedefs in
-  seivefwd.hh).
+1. Implement cell geometry stuff.
+   Compute Jacobian in cell.
 
-  Use MeshIOAscii to get mesh information into Python tests?
+   i. CellGeometry
+   ii. GeometryPoint
+   iii. GeometryLine
+   iv. GeometryTri
+   v. GeometryTet
+   vi. GeometryQuad
+   vii. GeometryHex
 
-0. Implement MeshIOLagrit
-   b. unit tests at C++ level
-     Check unit tests on big endian machine.
-
-1. Implement VTK output
-   a. SolutionIO
-     i. Python
-     ii. C++
-   b. SolutionIOVTK
-     i. Python
-     ii. C++
-
 2. Implement Dirichlet boundary conditions
    a. C++
    b. Python
@@ -82,9 +75,6 @@
          constructor
          initialize()
 
-     v. Update Reference cell
-       (1) Improve how we get Jacobian at vertices of cell
-
 4. Finish implementing ExplicitElasticity and Explicit
    a. Replace integrateConstant() with integrateResidual()
 
@@ -110,9 +100,13 @@
    d. bindings
    e. unit tests at Python level
 
-2. Implement HDF5 output
+2. Reimplement SolutionIO.
 
+   Follow implementation of MeshIO. SolutionIO implements extracting
+   data from Sieve and calls virtual functions to write data.
 
+   a. Reimplement SolutionIOVTK
+   b. Implement SolutionIOHDF5
 
 ======================================================================
 UNRESOLVED ISSUES

Modified: short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegrator.cc
===================================================================
--- short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegrator.cc	2007-05-11 23:08:21 UTC (rev 6858)
+++ short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegrator.cc	2007-05-11 23:18:12 UTC (rev 6859)
@@ -89,9 +89,6 @@
 { // _testIntegrateAction
   CPPUNIT_ASSERT(false);
 
-  typedef ALE::Mesh        Mesh;
-  typedef Mesh::real_section_type real_section_type;
-
   ALE::Obj<Mesh> mesh = _TestIntegrator::_setupMesh(data);
 
   // Fiber dimension (number of values in field per vertex) for fields
@@ -148,9 +145,6 @@
 { // _testIntegrate
   CPPUNIT_ASSERT(false);
 
-  typedef ALE::Mesh Mesh;
-  typedef Mesh::real_section_type real_section_type;
-
   journal::debug_t debug("TestIntegrator");
 
   try {
@@ -255,9 +249,6 @@
 ALE::Obj<ALE::Mesh>
 pylith::feassemble::_TestIntegrator::_setupMesh(const IntegratorData& data)
 { // _setupMesh
-  typedef ALE::Mesh Mesh;
-  typedef Mesh::sieve_type sieve_type;
-
   const int cellDim = data.cellDim;
   const int numCorners = data.numCorners;
   const int spaceDim = data.spaceDim;

Modified: short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegratorInertia.cc
===================================================================
--- short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegratorInertia.cc	2007-05-11 23:08:21 UTC (rev 6858)
+++ short/3D/PyLith/trunk/unittests/libtests/feassemble/TestIntegratorInertia.cc	2007-05-11 23:18:12 UTC (rev 6859)
@@ -48,9 +48,6 @@
   CPPUNIT_ASSERT(false);
 
 #if 0
-  typedef ALE::Mesh::real_section_type real_section_type;
-  typedef ALE::Mesh::topology_type topology_type;
-
   ALE::Obj<ALE::Mesh> mesh = _TestIntegratorInertia::_setupMesh(data);
   const ALE::Mesh::int_section_type::patch_type patch = 0;
 
@@ -106,9 +103,6 @@
 ALE::Obj<ALE::Mesh>
 pylith::feassemble::_TestIntegratorInertia::_setupMesh(const IntegratorData& data)
 { // _setupMesh
-  typedef ALE::Mesh::topology_type topology_type;
-  typedef topology_type::sieve_type sieve_type;
-
   const int cellDim = data.cellDim;
   const int numCorners = data.numCorners;
   const int spaceDim = data.spaceDim;

Modified: short/3D/PyLith/trunk/unittests/libtests/materials/TestElasticMaterial.cc
===================================================================
--- short/3D/PyLith/trunk/unittests/libtests/materials/TestElasticMaterial.cc	2007-05-11 23:08:21 UTC (rev 6858)
+++ short/3D/PyLith/trunk/unittests/libtests/materials/TestElasticMaterial.cc	2007-05-11 23:18:12 UTC (rev 6859)
@@ -48,10 +48,6 @@
 void
 pylith::materials::TestElasticMaterial::testCalcDensity(void)
 { // testCalcDensity
-  typedef ALE::Mesh Mesh;
-  typedef Mesh::sieve_type sieve_type;
-  typedef Mesh::real_section_type real_section_type;
-
   ALE::Obj<Mesh> mesh;
   { // create mesh
     const int cellDim = 1;
@@ -133,10 +129,6 @@
 void
 pylith::materials::TestElasticMaterial::testCalcStress(void)
 { // testCalcProperties
-  typedef ALE::Mesh Mesh;
-  typedef Mesh::sieve_type sieve_type;
-  typedef Mesh::real_section_type real_section_type;
-
   ALE::Obj<Mesh> mesh;
   { // create mesh
     const int cellDim = 1;
@@ -247,10 +239,6 @@
 void
 pylith::materials::TestElasticMaterial::testCalcDerivElastic(void)
 { // testCalcDerivElastic
-  typedef ALE::Mesh Mesh;
-  typedef Mesh::sieve_type sieve_type;
-  typedef Mesh::real_section_type real_section_type;
-
   ALE::Obj<Mesh> mesh;
   { // create mesh
     const int cellDim = 1;

Modified: short/3D/PyLith/trunk/unittests/libtests/materials/TestMaterial.cc
===================================================================
--- short/3D/PyLith/trunk/unittests/libtests/materials/TestMaterial.cc	2007-05-11 23:08:21 UTC (rev 6858)
+++ short/3D/PyLith/trunk/unittests/libtests/materials/TestMaterial.cc	2007-05-11 23:18:12 UTC (rev 6859)
@@ -77,11 +77,6 @@
 void
 pylith::materials::TestMaterial::testInitialize(void)
 { // testInitialize
-  typedef ALE::Mesh Mesh;
-  typedef Mesh::sieve_type sieve_type;
-  typedef Mesh::label_type label_type;
-  typedef Mesh::real_section_type real_section_type;
-
   ALE::Obj<Mesh> mesh;
   const int materialID = 24;
   { // create mesh
@@ -110,7 +105,7 @@
 
   { // set material ids
     const ALE::Obj<Mesh::label_sequence>& cells = mesh->heightStratum(0);
-    const ALE::Obj<label_type>& labelMaterials = mesh->createLabel("material-id");
+    const ALE::Obj<Mesh::label_type>& labelMaterials = mesh->createLabel("material-id");
     int i = 0;
     for(Mesh::label_sequence::iterator e_iter = cells->begin();
 	e_iter != cells->end();



More information about the cig-commits mailing list