[cig-commits] [commit] master: Writing &(variable) always strikes me as wrong because things in parentheses are expressions, and taking the address of an expression should yield, at best, a lambda function. I know that's pedantic but I know I'm a pedant and the patch makes me happy! (1e5a6da)

cig_noreply at geodynamics.org cig_noreply at geodynamics.org
Tue Jun 10 05:35:10 PDT 2014


Repository : https://github.com/geodynamics/aspect

On branch  : master
Link       : https://github.com/geodynamics/aspect/compare/be38df1b867b91a47da18192328a87479c360d20...75a1eead49c5165ff3ecee1573c3f4577ef534bb

>---------------------------------------------------------------

commit 1e5a6da2a5ad52b1a5187c629cb651a73b5e77a2
Author: Wolfgang Bangerth <bangerth at math.tamu.edu>
Date:   Mon Jun 9 21:15:20 2014 -0500

    Writing &(variable) always strikes me as wrong because things in parentheses
    are expressions, and taking the address of an expression should yield, at
    best, a lambda function. I know that's pedantic but I know I'm a pedant and
    the patch makes me happy!


>---------------------------------------------------------------

1e5a6da2a5ad52b1a5187c629cb651a73b5e77a2
 source/simulator/core.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/simulator/core.cc b/source/simulator/core.cc
index 01837fe..9951fed 100644
--- a/source/simulator/core.cc
+++ b/source/simulator/core.cc
@@ -1221,8 +1221,8 @@ namespace aspect
         distributed_mesh_velocity.reinit(introspection.index_sets.system_partitioning, mpi_communicator);
 
       std::vector<LinearAlgebra::BlockVector *> system_tmp (2);
-      system_tmp[0] = &(distributed_system);
-      system_tmp[1] = &(old_distributed_system);
+      system_tmp[0] = &distributed_system;
+      system_tmp[1] = &old_distributed_system;
 
       if (parameters.free_surface_enabled)
         system_tmp.push_back(&distributed_mesh_velocity);



More information about the CIG-COMMITS mailing list