[cig-commits] [commit] devel, master: removed the "goto 777" that was used to avoid the s362ani + attenuation bug in Hejun Zhu's routine (dc6d421)

[cig_noreply at geodynamics.org]

Repository : https://github.com/geodynamics/specfem3d_globe

On branches: devel,master
Link       : https://github.com/geodynamics/specfem3d_globe/compare/bc58e579b3b0838a0968725a076f5904845437ca...be63f20cbb6f462104e949894dbe205d2398cd7f

>---------------------------------------------------------------

commit dc6d421d909400c312aec3599e9d230aa4ec2964
Author: Dimitri Komatitsch <komatitsch at lma.cnrs-mrs.fr>
Date:   Fri May 23 23:14:11 2014 +0200

    removed the "goto 777" that was used to avoid the s362ani + attenuation bug in Hejun Zhu's routine


>---------------------------------------------------------------

dc6d421d909400c312aec3599e9d230aa4ec2964
 src/meshfem3D/meshfem3D_models.f90 | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/src/meshfem3D/meshfem3D_models.f90 b/src/meshfem3D/meshfem3D_models.f90
index aa673a8..62b346b 100644
--- a/src/meshfem3D/meshfem3D_models.f90
+++ b/src/meshfem3D/meshfem3D_models.f90
@@ -877,30 +877,6 @@
 
   else
 
-!! DK DK BUG
-!! DK DK BUG
-!! DK DK BUG since using the routines below is unsafe (see the above comment), I remove them for now
-!! DK DK BUG
-!! DK DK BUG
-    goto 777
-
-!! DK DK BUG
-!! DK DK BUG
-! the attenuation values for s362ani + ATTENUATION = .true. currently depend on the compiler used and on the compiler options used,
-! i.e. the lines below are unreliable. I am not sure why, it is probably either that elem_in_crust is not correctly set,
-! and / or that r_prem >(ONE-moho) is sensitive to roundoff noise and thus compiler-dependent,
-! in which case it should be changed to:
-!
-! if (r_prem - (ONE-moho) < some_epsilon_to_define) then...
-!      or something like that
-!
-! To be safe I have commented out the current code and checked that the bug (i.e. getting compiler-dependent results) is now gone.
-! If you fix that routine and check with Matthieu and Elliott that it then works fine on different machines
-! with different compilers please let us know and we will update the Git version
-! (including the master branch) and make an announcement to users.
-!! DK DK BUG
-!! DK DK BUG
-
     select case (REFERENCE_1D_MODEL)
 
       ! case(REFERENCE_MODEL_PREM)
@@ -935,13 +911,6 @@
 
     end select
 
-!! DK DK BUG
-!! DK DK BUG
-!! DK DK BUG since using the routines above is unsafe (see the above comment), I remove them for now
-!! DK DK BUG
-!! DK DK BUG
-  777 continue
-
   endif
 
   ! Get tau_e from tau_s and Qmu