[cig-commits] commit: Add a TODO and remove outdated comments.

Mercurial hg at geodynamics.org
Thu Mar 22 15:17:51 PDT 2012


changeset:   111:e23ec71c9981
user:        Walter Landry <wlandry at caltech.edu>
date:        Thu Mar 22 15:15:13 2012 -0700
files:       compute_Cxyz.cxx compute_v_on_interface/compute_v_on_interface.cxx
description:
Add a TODO and remove outdated comments.


diff -r afe687d9bde7 -r e23ec71c9981 compute_Cxyz.cxx
--- a/compute_Cxyz.cxx	Thu Mar 22 15:14:20 2012 -0700
+++ b/compute_Cxyz.cxx	Thu Mar 22 15:15:13 2012 -0700
@@ -57,6 +57,9 @@ void compute_Cxyz(const double zx[Nx+1][
 
           double p_jump=-2*eta_jump*dv(1);
 
+          /* TODO: dp_jump and ddz_jump both need to be corrected for
+             curvature and density jumps. */
+
           FTensor::Tensor1<double,2> dp_jump(2*eta_jump*ddv(n),
                                              -2*eta_jump*ddv(t));
 
diff -r afe687d9bde7 -r e23ec71c9981 compute_v_on_interface/compute_v_on_interface.cxx
--- a/compute_v_on_interface/compute_v_on_interface.cxx	Thu Mar 22 15:14:20 2012 -0700
+++ b/compute_v_on_interface/compute_v_on_interface.cxx	Thu Mar 22 15:15:13 2012 -0700
@@ -58,8 +58,6 @@ void compute_v_on_interface(const double
 
   if(xyz==0)
     {
-      /* Need to compute norm correctly when the interface is
-         horizontal and vertical */
       FTensor::Tensor1<double,2> norm, tangent;
       norm(0)=((disty[iy+1][jy] - disty[iy][jy])*(h-dx_j)
                + (disty[iy+2][jy] - disty[iy+1][jy])*dx_j)/(h*h);
@@ -76,8 +74,6 @@ void compute_v_on_interface(const double
     }
   else
     {
-      /* Need to compute norm correctly when the interface is
-         horizontal and vertical */
       FTensor::Tensor1<double,2> norm, tangent;
       norm(0)=((distx[ix+1][jx] - distx[ix][jx])*(h-dx_i)
                + (distx[ix+2][jx] - distx[ix+1][jx])*dx_i)/(h*h);



More information about the CIG-COMMITS mailing list