[CIG-MC] TeraGrid CitcomCU compile error

[Eh Tan]

Margarete Jadamec wrote:

>Hi Eh,
> I compiled CitcomCU on several TeraGrid sites. It compiled without error
>on bluegene at SDSC.
> But at tacc, anl, and ncsa I got an error message during compilation. It
>was a warning about nodes being out of bounds in Advection_diffusion.c. I
>attached a screen shot of the error from anl and also the source code for
>Advection_diffusion.c.
>Any suggestions?
>Thanks,
>Margarete
>
>
>
(The relevant error message is:

Advection_diffusion.c(685): warning *175: suvscript out of range
        nodes[4] = loc[loc[a].node_nebrs[0][0]].node_nebrs[2][2];
                   ^

Advection_diffusion.c(686): warning *175: suvscript out of range
        nodes[3] = loc[loc[a].node_nebrs[0][1]].node_nebrs[2][2];
                   ^
)


Hi Margarete,

Yes, the code has an index error. Fortunately, the code path is only 
executed when using (non zero) heat flux boundary conditions. Constant 
temperature or no heat flux boundary conditions are not affected.

The code around line 685, Advection_diffusion.c should be changed to:

          nodes[1] = loc[loc[a].node_nebrs[0][0]].node_nebrs[2][0];
          nodes[2] = loc[loc[a].node_nebrs[0][1]].node_nebrs[2][0];
          nodes[4] = loc[loc[a].node_nebrs[0][0]].node_nebrs[2][1];
          nodes[3] = loc[loc[a].node_nebrs[0][1]].node_nebrs[2][1];


The bug was in CitcomS as well and is fixed before v1.0 release. Since 
this bug is also in CitcomCU, it might present in other version of 
citcom family.


Eh