[CIG-SEISMO] bugfix, by mail after three failed pull request attempts

Lukas van de Wiel lukas.drinkt.thee at gmail.com
Tue Sep 5 02:45:21 PDT 2017


Dear Specfem development

when trying to run Specfem3D globe on GPU, I first had to fix a bug
that prevented device names longer than 12 characters.

Helpful as I am, I tried to make a pull request containing the fix.
Three times I tried and failed to get it past your build bot. The
first time it was obvious what I did wrong. The second and third time
I have no idea.

Could you tell me what I did wrong? It is probably in your git log.

Here is a git screenshot, so that you can add the fix manually:
https://i.imgur.com/i9M1wBZ.jpg

Cheers

Lukas


More information about the CIG-SEISMO mailing list