[CIG-SEISMO] bugfix, by mail after three failed pull request attempts

Dimitri Komatitsch komatitsch at lma.cnrs-mrs.fr
Tue Sep 5 14:21:09 PDT 2017


Hi Lukas,

Thanks! I have done it.

Cheers,
Dimitri.

On 09/05/2017 11:45 AM, Lukas van de Wiel wrote:
> Dear Specfem development
> 
> when trying to run Specfem3D globe on GPU, I first had to fix a bug
> that prevented device names longer than 12 characters.
> 
> Helpful as I am, I tried to make a pull request containing the fix.
> Three times I tried and failed to get it past your build bot. The
> first time it was obvious what I did wrong. The second and third time
> I have no idea.
> 
> Could you tell me what I did wrong? It is probably in your git log.
> 
> Here is a git screenshot, so that you can add the fix manually:
> https://i.imgur.com/i9M1wBZ.jpg
> 
> Cheers
> 
> Lukas
> _______________________________________________
> CIG-SEISMO mailing list
> CIG-SEISMO at geodynamics.org
> http://lists.geodynamics.org/cgi-bin/mailman/listinfo/cig-seismo
> 

-- 
Dimitri Komatitsch, CNRS Research Director (DR CNRS)
Laboratory of Mechanics and Acoustics, Marseille, France
http://komatitsch.free.fr


More information about the CIG-SEISMO mailing list