[CIG-SEISMO] Using Github Protected Branches

Wed Mar 14 14:43:14 PDT 2018

This conversation was originally started with the SPECFEM Admins Github
team. There were requests from other people to join the discussion so we
decided to post it to the mailing list.

Tyler Esser

---------- Forwarded message ----------
From: Tyler Esser <notifications at github.com>
Date: Fri, Mar 9, 2018 at 1:05 PM
Subject: [geodynamics/specfem-admins] Using Github's protected branches (#1)
To: geodynamics/specfem-admins <"SPECFEM Admins"@noreply.github.com>
Cc: Tyler Esser <tjesser at ucdavis.edu>, Your activity <
your_activity at noreply.github.com>

Hi SPECFEM admins,

CIG recently had a discussion with a CIG project dev about protecting
branches from certain actions and discovered that Github has a protected
branch feature. The option seems to be a good general practice and so I
wanted to ask what you thought about turning it on for SPECFEM master
branches. Github documentation for the feature is here:
https://help.github.com/articles/about-protected-branches/

Mostly we were interested in preventing accidental deletion or altering git
history with force pushing, but there are other options that may be worth
using. See the attached picture.

[image: protectedbranches]
<https://user-images.githubusercontent.com/15039903/37229838-3e206a58-239a-11e8-8849-4d53b31bb735.png>

The Github team interface seemed the best way to contact you when dealing
with Github administration issues. Please let me know if you would have
preferred a different method.

Tyler Esser

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/geodynamics/teams/specfem-admins/discussions/1>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOV9nzrbX2pJT4Ic82_OqHyMeMhIB0DGks5tcu6hgaJpZM4Sk3gA>
.

---------- Forwarded message ----------
From: daniel peter <notifications at github.com>
Date: Fri, Mar 9, 2018 at 11:20 PM
Subject: Re: [geodynamics/specfem-admins] Using Github's protected branches
(#1)
To: geodynamics/specfem-admins <"SPECFEM Admins"@noreply.github.com>
Cc: Tyler Esser <tjesser at ucdavis.edu>, Author <author at noreply.github.com>

Hi Tyler,

probably David has a better answer, since he put most of this already in
place. I think we already protect the master branch in all SPECFEM repos.
no pull requests are allowed on master by users. only admins are allowed to
push/merge commits to it. so the most important safeguards from above are
already in place.

as it seems to work pretty well so far for us, i don't see much need for
further restrictions.

best wishes,
daniel

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/geodynamics/teams/specfem-admins/discussions/1/comments/1>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOV9n0lH-Vma93h_RD2hoK0c6U4aI7Gaks5tc368gaJpZM4Sk3gA>
.

---------- Forwarded message ----------
From: Tyler Esser <notifications at github.com>
Date: Mon, Mar 12, 2018 at 5:18 PM
Subject: Re: [geodynamics/specfem-admins] Using Github's protected branches
(#1)
To: geodynamics/specfem-admins <"SPECFEM Admins"@noreply.github.com>
Cc: Tyler Esser <tjesser at ucdavis.edu>, Your activity <
your_activity at noreply.github.com>

When you say the master branch is already protected, are you referring to
Github branch protection or are you referring to the Github teams SPECFEM
Admins <https://github.com/orgs/geodynamics/teams/specfem-admins/members>
and SPECFEM Devs
<https://github.com/orgs/geodynamics/teams/specfem-developers/members>
being exclusive?

As far as I can tell, the people in those teams have permission to push,
merge, force push, and/or delete any branch in the SPECFEM repos. If I
understand you correctly, that's fine because everyone in those teams is
already trusted. Is that correct?

Tyler

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/geodynamics/teams/specfem-admins/discussions/1/comments/2>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOV9nyUcEMGqU9oUvZeIZYzYee5129W9ks5tdxBkgaJpZM4Sk3gA>
.

---------- Forwarded message ----------
From: daniel peter <notifications at github.com>
Date: Tue, Mar 13, 2018 at 1:46 AM
Subject: Re: [geodynamics/specfem-admins] Using Github's protected branches
(#1)
To: geodynamics/specfem-admins <"SPECFEM Admins"@noreply.github.com>
Cc: Tyler Esser <tjesser at ucdavis.edu>, Author <author at noreply.github.com>

the master branch is protected by buildbot, which David set up. every pull
request goes through buildbot which will close it automatically if the
request is towards the master branch.

and yes, only those team admins are allowed to push, merge, etc. on the
master/devel branch which is fine, as they probably know what they're doing
:)

-daniel

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/geodynamics/teams/specfem-admins/discussions/1/comments/3>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOV9n6HUbKXXf0UdPXfPH9BEZBAhWekyks5td4d-gaJpZM4Sk3gA>
.

---------- Forwarded message ----------
From: Tyler Esser <notifications at github.com>
Date: Wed, Mar 14, 2018 at 12:09 PM
Subject: Re: [geodynamics/specfem-admins] Using Github's protected branches
(#1)
To: geodynamics/specfem-admins <"SPECFEM Admins"@noreply.github.com>
Cc: Tyler Esser <tjesser at ucdavis.edu>, Your activity <
your_activity at noreply.github.com>

There's been a few requests to join this discussion. Do you mind if I copy
this thread to the cig-seismo mailing list?

Tyler

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/geodynamics/teams/specfem-admins/discussions/1/comments/4>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOV9nzlkfKRWyqhmOX1y-zJG6VFZKEobks5teWrngaJpZM4Sk3gA>
.

---------- Forwarded message ----------
From: daniel peter <notifications at github.com>
Date: Wed, Mar 14, 2018 at 1:49 PM
Subject: Re: [geodynamics/specfem-admins] Using Github's protected branches
(#1)
To: geodynamics/specfem-admins <"SPECFEM Admins"@noreply.github.com>
Cc: Tyler Esser <tjesser at ucdavis.edu>, Author <author at noreply.github.com>

sure, let's see some more opinions :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/geodynamics/teams/specfem-admins/discussions/1/comments/5>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOV9n9qaWMmQTY0OsoY2qXDakvb2EIIlks5teYJngaJpZM4Sk3gA>
.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geodynamics.org/pipermail/cig-seismo/attachments/20180314/27cad891/attachment.html>